feat: markdown editor#1002
Merged
Merged
Conversation
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request migrates the markdown editor from react-mde to @uiw/react-md-editor. The change includes removing the old markdown editor package, updating the GenericDescription component to use the new editor, removing now-unused utility functions and constants, and updating styles to work with the new editor library.
Changes:
- Replaced
react-mdepackage with@uiw/react-md-editorin dependencies - Refactored GenericDescription component to use MDEditor with custom command icons
- Removed deprecated markdown editor utilities, constants, and type definitions
- Updated SCSS styles for the new editor component
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed react-mde, added @uiw/react-md-editor |
| package-lock.json | Updated lock file with new dependencies for the new markdown editor |
| GenericDescription.tsx | Migrated from ReactMde to MDEditor component with new state management |
| genericDescription.scss | Removed old editor styles, added styles for new w-md-editor component |
| constant.ts | Deleted file - markdown editor constants no longer needed |
| utils.tsx | Removed getEditorCustomIcon function |
| types.ts | Removed tabIndex, minEditorHeight, and MDEditorSelectedTabType |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd improved state management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates the markdown editor in
GenericDescriptionfromreact-mdeto@uiw/react-md-editor, modernizing the editing experience and simplifying the code. It also introduces a custom toolbar with icon-based commands and improves the structure and maintainability of related constants.Markdown Editor Migration and UI Improvements:
react-mdemarkdown editor with@uiw/react-md-editorinGenericDescription.tsx, resulting in a more modern editor experience and a simplified component structure. The state management and toolbar logic were refactored accordingly. [1] [2] [3] [4] [5] [6] [7]Toolbar Customization and Iconography:
TOOLBAR_SECONDARY_COMMANDSconstant, and integrated these into the editor toolbar.Code Organization and Cleanup:
constant.tsto a newconstant.tsxfile, improving maintainability and aligning with the new editor implementation. [1] [2]Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist